Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Linking and unlinking channels based on the loaded list of channels" #3465

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Revert "Linking and unlinking channels based on the loaded list of channels" #3465

merged 2 commits into from
Oct 17, 2024

Conversation

nuno-vieira
Copy link
Member

No description provided.

@nuno-vieira nuno-vieira requested a review from a team as a code owner October 17, 2024 14:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

1 Warning
⚠️ Please provide a summary in the Pull Request description

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 11.68 ms -16.8% 🔽 🔴
Duration 2.6 s 2.54 s 2.31% 🔼 🟢
Hitch time ratio 4 ms per s 4.58 ms per s -14.5% 🔽 🔴
Frame rate 75 fps 78.59 fps 4.79% 🔼 🟢
Number of hitches 1 0.6 40.0% 🔼 🟢

@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Oct 17, 2024 •
edited
Loading

SDK Size

title develop branch diff status
StreamChat 6.92 MB 6.92 MB -1 KB 🚀
StreamChatUI 4.95 MB 4.95 MB 0 KB 🟢

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
164 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.3% Coverage on New Code
0.1% Duplication on New Code

See analysis details on SonarCloud

@nuno-vieira nuno-vieira merged commit e2acb9d into develop Oct 17, 2024
13 of 14 checks passed
@nuno-vieira nuno-vieira deleted the fix/revert-linking branch October 17, 2024 16:58
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuno-vieira @Stream-SDK-Bot @martinmitrevski